Skip to content

Conversation

tishun
Copy link
Collaborator

@tishun tishun commented Jun 16, 2025

Provide basic support for RediSearch as part of #2746

This implementation will provide support for:

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@tishun tishun force-pushed the feature/redisearch branch from 46080a3 to ab76b4b Compare June 16, 2025 15:57
@tishun tishun changed the base branch from main to feature/redisearch July 14, 2025 07:31
@tishun tishun marked this pull request as ready for review July 14, 2025 07:31
@tishun tishun deleted the branch redis:feature/redisearch July 14, 2025 10:14
@tishun tishun closed this Jul 14, 2025
@tishun tishun reopened this Jul 14, 2025
tishun and others added 7 commits July 14, 2025 20:12
* Add support for FT.DROPINDEX redis#2722

* Polishing
Vibe code the FT.SEARCH command
Pulled latest from the integration branch

Fixed a lot of the hallucinations

RESP2 parser improvements

JSON Indexing tests

Add some advanced use-cases

Fixed all integration tests

Fixed schema fields, added vector tests, but they are all failing

Fixed vector search tests

Improve coverage of integration and unit tests

One unit test fails
Fixing the integration tests for FT.AGGREGATE

Polishing 1/3

Add more documentation ot the AggregateArgs
Add Integration tests for the FT.CURSOR

Add RESP2 tests for all aggragation integration tests
@tishun tishun force-pushed the feature/redisearch branch from 3bac4d2 to 827b940 Compare July 14, 2025 17:14
tishun added 2 commits July 15, 2025 15:24
Fixing unit tests (part2)
Fixing unit tests (part3)
@tishun tishun merged commit 22ef96e into redis:feature/redisearch Jul 15, 2025
6 checks passed
Copy link
Collaborator

@uglide uglide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted one more deprecated argument for FT.Search

tishun added a commit that referenced this pull request Aug 7, 2025
* RediSearch support (part 1 of 3) (#3325)

* Revert "Revert "Add support for FT.CREATE #2717 (#3150)" (#3160)" (#3161)

This reverts commit 319e315.

* Add support for FT.DROPINDEX #2722 (#3164)

* Add support for FT.DROPINDEX #2722

* Polishing

* FT.SEARCH added

Vibe code the FT.SEARCH command
Pulled latest from the integration branch

Fixed a lot of the hallucinations

RESP2 parser improvements

JSON Indexing tests

Add some advanced use-cases

Fixed all integration tests

Fixed schema fields, added vector tests, but they are all failing

Fixed vector search tests

Improve coverage of integration and unit tests

One unit test fails

* API cleanup, added Kotlin implementation

* Implement the FT.AGGREGATE command

Fixing the integration tests for FT.AGGREGATE

Polishing 1/3

Add more documentation ot the AggregateArgs

* Implement the FT.CURSOR command

Add Integration tests for the FT.CURSOR

Add RESP2 tests for all aggragation integration tests

* FT.AGGREGATE was never working in the first place, now it is working, but for RESP3 only

* Fixing unit tests (part1)
Fixing unit tests (part2)
Fixing unit tests (part3)

* Polishing (part 1)

* RediSearch support (part 2 of 3) (#3360)

Introducing the FT.ALTER

Introducing the FT.ALIASADD, FT.ALIASUPDATE, FT.ALIASDEL

Introducing the FT.TAGVALS

* RediSearch support (part 3 of 3) (#3364)

* Introducing the FT.SUGADD FT.SUGDEL FT.SUGGET and FT.SUGLEN

* Introducing the FT.DICTADD, FT.DICTDEL, FT.DICTDUMP

* Introducing the FT.SPELLCHECK

* Introducing the FT.SPELLCHECK (polishing)

* Introducing the FT.EXPLAIN, FT.SYNUPDATE, FT.SYNDUMP, FT._LIST

* Introducing the FT.PROFILE

Polishing 1

Polishing 1

* Polishing 2

* Removing the FT.PROFILE command entirely

* Polishing 3

* Polishing 4

* RediSearch with Lettuce - final fixes (#3371)

* Fix wrong aggregation arguments order
Docs part (to squash later)
Modified CreateArgs and SearchArgs
Address review comments 1/many
Addressed review comment by Igor, more polishing

* Cluster tests

* Extend wordlist

* Extend wordlist 2

* Avoid NPE when empty result received

* Avoid NPE when empty result received 2

* Disable cluster tests for 7.2 and 7.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants