Skip to content

Fixed SocketOptions.Builder validation messages #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025
Merged

Fixed SocketOptions.Builder validation messages #3366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/java/io/lettuce/core/SocketOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ private Builder() {
*/
public Builder connectTimeout(Duration connectTimeout) {

LettuceAssert.notNull(connectTimeout, "Connection timeout must not be null");
LettuceAssert.notNull(connectTimeout, "Connect timeout must not be null");
LettuceAssert.isTrue(connectTimeout.toNanos() > 0, "Connect timeout must be greater 0");

this.connectTimeout = connectTimeout;
Expand All @@ -149,7 +149,7 @@ public Builder connectTimeout(Duration connectTimeout) {
public Builder connectTimeout(long connectTimeout, TimeUnit connectTimeoutUnit) {

LettuceAssert.isTrue(connectTimeout > 0, "Connect timeout must be greater 0");
LettuceAssert.notNull(connectTimeoutUnit, "TimeUnit must not be null");
LettuceAssert.notNull(connectTimeoutUnit, "Connect timeout unit must not be null");

return connectTimeout(Duration.ofNanos(connectTimeoutUnit.toNanos(connectTimeout)));
}
Expand Down Expand Up @@ -422,7 +422,7 @@ public KeepAliveOptions.Builder enable(boolean enabled) {
public KeepAliveOptions.Builder idle(Duration idle) {

LettuceAssert.notNull(idle, "Idle time must not be null");
LettuceAssert.isTrue(!idle.isNegative(), "Idle time must not be begative");
LettuceAssert.isTrue(!idle.isNegative(), "Idle time must not be negative");

this.idle = idle;
return this;
Expand All @@ -439,8 +439,8 @@ public KeepAliveOptions.Builder idle(Duration idle) {
*/
public KeepAliveOptions.Builder interval(Duration interval) {

LettuceAssert.notNull(interval, "Idle time must not be null");
LettuceAssert.isTrue(!interval.isNegative(), "Idle time must not be begative");
LettuceAssert.notNull(interval, "Interval time must not be null");
LettuceAssert.isTrue(!interval.isNegative(), "Interval time must not be negative");

this.interval = interval;
return this;
Expand Down