reuse-objectmapper-defaultjsonparser #3372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor DefaultJsonParser to use a single static ObjectMapper instance instead of creating new instances for each method call, improving performance and memory usage.
|
Can this be specified through options? For example, specifying a DefaultJsonParser instance, allowing replacement with different implementations, and permitting the passing of an ObjectMapper instance—such as one from a configured Spring container that has modules installed or some configurations applied. |
|
@thachlp If no ObjectMapper is specified in DefaultJsonParser, a new one will be created; otherwise, the specified instance will be used. |
|
@cjdxhjj let me repeat what you suggested to make sure we are on the same page: you'd like to be able to pass an existing instance of the @thachlp I think it makes sense to be able to have the following logic:
Does that make sense? |
|
@thachlp yes, that right.In my case, some custom serialization has been implemented. For example, Kotlin, Scala, and Long types are serialized into strings to support the frontend, etc. Therefore, using that existing instance might be more appropriate than creating a new one. Of course, users are completely free to customize what kind of instance to create. |
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Aug 8, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [io.lettuce:lettuce-core](https://github.com/redis/lettuce) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.7.1.RELEASE` -> `6.8.0.RELEASE` | | [com.squareup.wire](https://github.com/square/wire) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `5.3.7` -> `5.3.8` | | [com.squareup.wire:wire-schema](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.7` -> `5.3.8` | | [com.squareup.wire:wire-runtime](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.7` -> `5.3.8` | | [com.squareup.wire:wire-reflector](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.7` -> `5.3.8` | | [com.squareup.wire:wire-moshi-adapter](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.7` -> `5.3.8` | | [com.squareup.wire:wire-grpc-client](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.7` -> `5.3.8` | | [com.squareup.wire:wire-bom](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.7` -> `5.3.8` | --- ### Release Notes <details> <summary>redis/lettuce (io.lettuce:lettuce-core)</summary> ### [`v6.8.0.RELEASE`](https://github.com/redis/lettuce/releases/tag/6.8.0.RELEASE) [Compare Source](redis/lettuce@6.7.1.RELEASE...6.8.0.RELEASE) The Lettuce team is pleased to announce the Lettuce 6.8.0 minor release! This release provides support for the newly introduced [Redis Query Engine support](https://redis.github.io/lettuce/user-guide/redis-search/) which was is part of Redis 8.0 and previously - as part of RedisStack. The new operators (`DIFF`, `DIFF1`, `ANDOR` and `ONE`) for the `BITOP` command are also available. The team has worked on extending the contract of the `XADD` and `XTRIM ` commands to support trimming policy, and also introduced the new `XDELEX` and `XACKDEL` commands. Lettuce 6.8.0 supports Redis 2.6+ up to Redis 8.x. In terms of Java runtime, Lettuce requires at least Java 8 and works with Java 24. The driver is tested against Redis 8.2, Redis 8.0, Redis 7.4 and Redis 7.2. Find the full changelog at the end of this document. Thanks to all contributors who made Lettuce 6.8.0.RELEASE possible. 📗 Links Reference documentation: https://lettuce.io/core/6.8.0.RELEASE/reference/ Javadoc: https://lettuce.io/core/6.8.0.RELEASE/api/ ⭐ New Features Introduce RediSearch by [@​tishun](https://github.com/tishun) in redis/lettuce#3375 Add support for new operations of BITOP command in Redis Community Edition 8.2 by [@​atakavci](https://github.com/atakavci) in redis/lettuce#3334 Add support for 8.2 stream commands by [@​uglide](https://github.com/uglide) in redis/lettuce#3374 🐞 Bug Fixes NoClassDefFoundError in Lettuce 6.7.0 [#​3317](redis/lettuce#3317) by [@​tishun](https://github.com/tishun) in redis/lettuce#3318 💡 Other The instance of the `ObjectMapper` can now be reused in the `DefaultJsonParser` by [@​thachlp](https://github.com/thachlp) in redis/lettuce#3372 Added basic connection interruption tests by [@​uglide](https://github.com/uglide) in redis/lettuce#3292 DOC-4758 async JSON doc examples by [@​andy-stark-redis](https://github.com/andy-stark-redis) in redis/lettuce#3335 Fixed SocketOptions.Builder validation messages by [@​hubertchylik](https://github.com/hubertchylik) in redis/lettuce#3366 Refactor tests for clarity and maintainability by [@​Rian-Ismael](https://github.com/Rian-Ismael) in redis/lettuce#3363 Provide support for the SVS-VMANA index ([#​3385](redis/lettuce#3385)) by [@​tishun](https://github.com/tishun) in redis/lettuce#3386 ❤️ New Contributors## New Contributors - [@​hubertchylik](https://github.com/hubertchylik) made their first contribution in redis/lettuce#3366 **Full Changelog**: redis/lettuce@6.7.0.RELEASE...6.8.0.RELEASE </details> <details> <summary>square/wire (com.squareup.wire)</summary> ### [`v5.3.8`](https://github.com/square/wire/blob/HEAD/CHANGELOG.md#Version-538) [Compare Source](square/wire@5.3.7...5.3.8) *2025-08-08* ##### Swift - Fix edge case for oneof field named `self` ([#​3360](square/wire#3360) by \[Dimitris Koutsogiorgas]\[dnkoutso]) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: f26d0f3a5bf8e0f695433640efc9d6e93850ab60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor DefaultJsonParser to use a single static ObjectMapper instance instead of creating new instances for each method call, improving performance and memory usage.
Closes #3370
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.