Skip to content

Add support for BF.CARD command #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Add support for BF.CARD command #2376

merged 4 commits into from
Jan 18, 2023

Conversation

shacharPash
Copy link
Contributor

@shacharPash shacharPash commented Jan 12, 2023

Description

Describe your pull request here


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Fix #2360

@shacharPash shacharPash marked this pull request as draft January 12, 2023 14:55
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Base: 95.85% // Head: 95.86% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (da08a64) compared to base (c5b6f77).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2376   +/-   ##
=======================================
  Coverage   95.85%   95.86%           
=======================================
  Files         449      450    +1     
  Lines        4224     4229    +5     
  Branches      471      471           
=======================================
+ Hits         4049     4054    +5     
  Misses        107      107           
  Partials       68       68           
Impacted Files Coverage Δ
packages/bloom/lib/commands/bloom/CARD.ts 100.00% <100.00%> (ø)
packages/bloom/lib/commands/bloom/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash marked this pull request as ready for review January 15, 2023 08:53
@leibale leibale merged commit a55fbaf into master Jan 18, 2023
@leibale leibale deleted the bf-card branch January 18, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for BF.CARD
3 participants