fix #2419 - fix RESP2 array decoder in edge cases #2424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for troubleshooting this. I figured it was something having to do with chunks splitting data in an "improper" place since the frequency of the hangs increased with the number of chunks that came through. |
florian-schunk
pushed a commit
to florian-schunk/node-redis
that referenced
this pull request
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fast-facts it actually is a bug in the decoder that happens in a very rare edge case: an array that contains an empty array, and the inner array data comes in 2 chunks, and the split is exactly between the 0 and the \r\n (i.e
*1\r\n*0\r\n).