Skip to content

V5 branch #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Apr 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
935993a
wip
leibale Apr 5, 2023
7f880a6
Worked on phrasing etc for v5 doc changes.
Apr 6, 2023
02b3bee
Removed quite repetition of 'Rather'
Apr 6, 2023
5c6fb19
Update v4-to-v5.md
leibale Apr 10, 2023
1d6c780
Update v4-to-v5.md
leibale Apr 10, 2023
35d32e5
Update v4-to-v5.md
leibale Apr 22, 2023
9faa3e7
WIP
leibale Apr 23, 2023
40cfb94
WIP
leibale Apr 24, 2023
39bcac6
clean SET command
leibale Apr 24, 2023
b272f18
some more commands, multi.exec<'typed'>
leibale Apr 24, 2023
567ae38
"typed" multi
leibale Apr 25, 2023
e25bcff
WIP
leibale Apr 26, 2023
623f229
Merge branch 'master' of github.com:redis/node-redis into v5
leibale Apr 26, 2023
ae0d352
upgrade deps
leibale Apr 26, 2023
cf7d4cc
wip
leibale Apr 26, 2023
0fbf78a
wip
leibale Apr 26, 2023
126d2cc
fix #2469
leibale Apr 26, 2023
aae501e
wip
leibale Apr 26, 2023
feae3d1
npm update
leibale Apr 26, 2023
11c1738
wip
leibale Apr 26, 2023
fe7ca91
Merge branch 'master' of github.com:redis/node-redis into v5
leibale Apr 26, 2023
c78f335
wip
leibale Apr 26, 2023
1254ff7
wip
leibale Apr 26, 2023
7bacad2
wip
leibale Apr 27, 2023
53ac48f
some tests
leibale Apr 27, 2023
69767d4
tests.yml
leibale Apr 27, 2023
ab3973a
wip
leibale Apr 27, 2023
8d615e9
wip
leibale Apr 27, 2023
547132a
merge master into v5
leibale Apr 30, 2023
2c4dc95
Merge branch 'master' of github.com:redis/node-redis into v5
leibale Apr 30, 2023
53b9397
some more commands
leibale Apr 30, 2023
88333c0
some more commands
leibale Apr 30, 2023
e04609c
WIP
leibale Apr 30, 2023
a5d0963
Release [email protected]
leibale Apr 30, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
File renamed without changes.
6 changes: 2 additions & 4 deletions .github/workflows/documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,13 @@ jobs:
documentation:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.3.4
- uses: actions/checkout@v3
with:
fetch-depth: 1
- name: Use Node.js
uses: actions/setup-node@v2.3.0
uses: actions/setup-node@v3
- name: Install Packages
run: npm ci
- name: Build tests tools
run: npm run build:tests-tools
- name: Generate Documentation
run: npm run documentation
- name: Upload
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: ['14', '16', '18', '19']
redis-version: ['5', '6.0', '6.2', '7.0']
node-version: ['16', '18', '19', '20']
redis-version: ['5', '6.0', '6.2', '7.0', '7.2-rc']
steps:
- uses: actions/checkout@v2.3.4
- uses: actions/checkout@v3
with:
fetch-depth: 1
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2.3.0
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Update npm
Expand All @@ -32,7 +32,7 @@ jobs:
- name: Install Packages
run: npm ci
- name: Build tests tools
run: npm run build:tests-tools
run: npm run build:client && npm run build:test-utils
- name: Run Tests
run: npm run test -- -- --forbid-only --redis-version=${{ matrix.redis-version }}
- name: Upload to Codecov
Expand Down
340 changes: 2 additions & 338 deletions README.md

Large diffs are not rendered by default.

20 changes: 20 additions & 0 deletions benchmark/lib/ping/ioredis-auto-pipeline.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import Redis from 'ioredis';

export default async (host) => {
const client = new Redis({
host,
lazyConnect: true,
enableAutoPipelining: true
});

await client.connect();

return {
benchmark() {
return client.ping();
},
teardown() {
return client.disconnect();
}
}
};
21 changes: 21 additions & 0 deletions benchmark/lib/ping/local-resp2.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { createClient } from 'redis-local';

export default async (host) => {
const client = createClient({
socket: {
host
},
RESP: 2
});

await client.connect();

return {
benchmark() {
return client.ping();
},
teardown() {
return client.disconnect();
}
};
};
27 changes: 27 additions & 0 deletions benchmark/lib/ping/local-resp3-module-with-flags.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import { createClient } from 'redis-local';
import PING from 'redis-local/dist/lib/commands/PING.js';

export default async (host) => {
const client = createClient({
socket: {
host
},
RESP: 3,
modules: {
module: {
ping: PING.default
}
}
});

await client.connect();

return {
benchmark() {
return client.withFlags({}).module.ping();
},
teardown() {
return client.disconnect();
}
};
};
27 changes: 27 additions & 0 deletions benchmark/lib/ping/local-resp3-module.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import { createClient } from 'redis-local';
import PING from 'redis-local/dist/lib/commands/PING.js';

export default async (host) => {
const client = createClient({
socket: {
host
},
RESP: 3,
modules: {
module: {
ping: PING.default
}
}
});

await client.connect();

return {
benchmark() {
return client.module.ping();
},
teardown() {
return client.disconnect();
}
};
};
21 changes: 21 additions & 0 deletions benchmark/lib/ping/local-resp3.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { createClient } from 'redis-local';

export default async (host) => {
const client = createClient({
socket: {
host
},
RESP: 3
});

await client.connect();

return {
benchmark() {
return client.ping();
},
teardown() {
return client.disconnect();
}
};
};
2 changes: 1 addition & 1 deletion benchmark/lib/ping/v4.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createClient } from '@redis/client';
import { createClient } from 'redis-v4';

export default async (host) => {
const client = createClient({
Expand Down
12 changes: 6 additions & 6 deletions benchmark/lib/runner.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,13 @@ const benchmarkStart = process.hrtime.bigint(),
histogram = await run(times),
benchmarkNanoseconds = process.hrtime.bigint() - benchmarkStart,
json = {
timestamp,
// timestamp,
operationsPerSecond: times / Number(benchmarkNanoseconds) * 1_000_000_000,
p0: histogram.getValueAtPercentile(0),
p50: histogram.getValueAtPercentile(50),
p95: histogram.getValueAtPercentile(95),
p99: histogram.getValueAtPercentile(99),
p100: histogram.getValueAtPercentile(100)
// p0: histogram.getValueAtPercentile(0),
// p50: histogram.getValueAtPercentile(50),
// p95: histogram.getValueAtPercentile(95),
// p99: histogram.getValueAtPercentile(99),
// p100: histogram.getValueAtPercentile(100)
};
console.log(`[${basename(path)}]:`);
console.table(json);
Expand Down
Loading