Restoring ZRANGE desc for Redis < 6.2.0 #1697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
closes #1669
In the previous implementation of zrange, the user could use
desc
by calling to zrevrange behind the scene. Since redis 6.2.0, zrange supportsREV
label (and other new labels e.g LIMIT).We want to be able to use desc without any other params (that will execute zrevrange), or to use
desc
with other new params, and then zrange will be called, but that can be done only when using redis > 6.2.0.