-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove unused aggregation subclasses #1754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused aggregation subclasses #1754
Conversation
Merge master
Codecov Report
@@ Coverage Diff @@
## master #1754 +/- ##
=======================================
Coverage 90.89% 90.89%
=======================================
Files 59 59
Lines 14229 14203 -26
=======================================
- Hits 12933 12910 -23
+ Misses 1296 1293 -3
Continue to review full report at Codecov.
|
@AvitalFineRedis can you please resolve? |
Ready |
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
The tests that check these methods already merged, so it should not break anything.