Skip to content

Remove unused aggregation subclasses #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Nov 29, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

The tests that check these methods already merged, so it should not break anything.

@codecov-commenter
Copy link

Codecov Report

Merging #1754 (12d8600) into master (12f45ee) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1754   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files          59       59           
  Lines       14229    14203   -26     
=======================================
- Hits        12933    12910   -23     
+ Misses       1296     1293    -3     
Impacted Files Coverage Δ
redis/commands/search/aggregation.py 79.41% <100.00%> (-2.69%) ⬇️
tests/test_cluster.py 98.60% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4db85ef...12d8600. Read the comment docs.

@chayim
Copy link
Contributor

chayim commented Nov 30, 2021

@AvitalFineRedis can you please resolve?

@AvitalFineRedis
Copy link
Contributor Author

@AvitalFineRedis can you please resolve?

Ready

@chayim chayim merged commit e16e26e into redis:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants