-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add support for HSET items #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2006 +/- ##
==========================================
- Coverage 92.63% 92.63% -0.01%
==========================================
Files 100 100
Lines 20921 20962 +41
==========================================
+ Hits 19381 19418 +37
- Misses 1540 1544 +4
Continue to review full report at Codecov.
|
@mdczaplicki Well this is just awesome, and on the heels of 4.2.0rc1! Approved for 4.2.0rc1. Nice catch! |
Oy @mdczaplicki sorry, I missed merging this into 4.2.0rc1. I've merged the latest master in, to make sure it plays nice - and we'll merge this in for 4.2.0rc2. Again, my apologies - that wasn't nice of me. |
Absolutely no worries my friend. You're doing great job, keep it going!
Thanks. :D
…On Thu, 24 Feb 2022, 15:16 Chayim, ***@***.***> wrote:
Oy @mdczaplicki <https://github.com/mdczaplicki> sorry, I missed merging
this into 4.2.0rc1. I've merged the latest master in, to make sure it plays
nice - and we'll merge this in for 4.2.0rc2. Again, my apologies - that
wasn't nice of me.
—
Reply to this email directly, view it on GitHub
<#2006 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACFPY2UMIXW47J3H6D4DOHDU4Y4S7ANCNFSM5PBOXLOA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
* Add `items` parameter to `hset` * Add test for `hset` with `items` * Update CHANGES * fix test_profile Co-authored-by: Chayim <[email protected]> Co-authored-by: dvora-h <[email protected]>
* command docs * Add support for AUTH (#1929) * Add support for AUTH * Fix linter error * test fix * fix test in cluster Co-authored-by: Chayim <[email protected]> Co-authored-by: Chayim I. Kirshen <[email protected]> Co-authored-by: dvora-h <[email protected]> * Add support for JSON, TIMESERIES, BLOOM & GRAPH commands in cluster (#2032) Co-authored-by: Chayim <[email protected]> * Add support for HSET items (#2006) * Add `items` parameter to `hset` * Add test for `hset` with `items` * Update CHANGES * fix test_profile Co-authored-by: Chayim <[email protected]> Co-authored-by: dvora-h <[email protected]> * Add cluster support for functions (#2016) * cluster support for functions * fix test_list_on_cluster mark * fix mark * cluster unstable url * fix * fix cluster url * skip tests * linters * linters * skip test Co-authored-by: Chayim <[email protected]> Co-authored-by: dogukanteber <[email protected]> Co-authored-by: Chayim I. Kirshen <[email protected]> Co-authored-by: Marek Czaplicki <[email protected]>
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Allow passing
items
tohset
.