Skip to content

Fix GRAPH.LIST & TDIGEST.QUANTILE tests #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2022
Merged

Fix GRAPH.LIST & TDIGEST.QUANTILE tests #2335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
586ffe8
fix graph list_keys test
dvora-h Aug 14, 2022
9f57d31
async test
dvora-h Aug 14, 2022
37360e6
fix tdigest.quantile
dvora-h Aug 14, 2022
776170f
fix
dvora-h Aug 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/test_asyncio/test_bloom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,21 +366,21 @@ async def test_tdigest_quantile(modclient: redis.Redis):
# assert min min/max have same result as quantile 0 and 1
assert (
await modclient.tdigest().max("tDigest")
== (await modclient.tdigest().quantile("tDigest", 1.0))[1]
== (await modclient.tdigest().quantile("tDigest", 1.0))[0]
)
assert (
await modclient.tdigest().min("tDigest")
== (await modclient.tdigest().quantile("tDigest", 0.0))[1]
== (await modclient.tdigest().quantile("tDigest", 0.0))[0]
)

assert 1.0 == round((await modclient.tdigest().quantile("tDigest", 0.01))[1], 2)
assert 99.0 == round((await modclient.tdigest().quantile("tDigest", 0.99))[1], 2)
assert 1.0 == round((await modclient.tdigest().quantile("tDigest", 0.01))[0], 2)
assert 99.0 == round((await modclient.tdigest().quantile("tDigest", 0.99))[0], 2)

# test multiple quantiles
assert await modclient.tdigest().create("t-digest", 100)
assert await modclient.tdigest().add("t-digest", [1, 2, 3, 4, 5], [1.0] * 5)
res = await modclient.tdigest().quantile("t-digest", 0.5, 0.8)
assert [0.5, 3.0, 0.8, 5.0] == res
assert [3.0, 5.0] == res


@pytest.mark.redismod
Expand Down
4 changes: 2 additions & 2 deletions tests/test_asyncio/test_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,11 +348,11 @@ async def test_list_keys(modclient: redis.Redis):
result = await modclient.graph().list_keys()
assert result == []

await modclient.execute_command("GRAPH.EXPLAIN", "G", "RETURN 1")
await modclient.graph("G").query("CREATE (n)")
result = await modclient.graph().list_keys()
assert result == ["G"]

await modclient.execute_command("GRAPH.EXPLAIN", "X", "RETURN 1")
await modclient.graph("X").query("CREATE (m)")
result = await modclient.graph().list_keys()
assert result == ["G", "X"]

Expand Down
10 changes: 5 additions & 5 deletions tests/test_bloom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,17 +365,17 @@ def test_tdigest_quantile(client):
)
# assert min min/max have same result as quantile 0 and 1
res = client.tdigest().quantile("tDigest", 1.0)
assert client.tdigest().max("tDigest") == res[1]
assert client.tdigest().max("tDigest") == res[0]
res = client.tdigest().quantile("tDigest", 0.0)
assert client.tdigest().min("tDigest") == res[1]
assert client.tdigest().min("tDigest") == res[0]

assert 1.0 == round(client.tdigest().quantile("tDigest", 0.01)[1], 2)
assert 99.0 == round(client.tdigest().quantile("tDigest", 0.99)[1], 2)
assert 1.0 == round(client.tdigest().quantile("tDigest", 0.01)[0], 2)
assert 99.0 == round(client.tdigest().quantile("tDigest", 0.99)[0], 2)

# test multiple quantiles
assert client.tdigest().create("t-digest", 100)
assert client.tdigest().add("t-digest", [1, 2, 3, 4, 5], [1.0] * 5)
assert [0.5, 3.0, 0.8, 5.0] == client.tdigest().quantile("t-digest", 0.5, 0.8)
assert [3.0, 5.0] == client.tdigest().quantile("t-digest", 0.5, 0.8)


@pytest.mark.redismod
Expand Down
4 changes: 2 additions & 2 deletions tests/test_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,11 +366,11 @@ def test_list_keys(client):
result = client.graph().list_keys()
assert result == []

client.execute_command("GRAPH.EXPLAIN", "G", "RETURN 1")
client.graph("G").query("CREATE (n)")
result = client.graph().list_keys()
assert result == ["G"]

client.execute_command("GRAPH.EXPLAIN", "X", "RETURN 1")
client.graph("X").query("CREATE (m)")
result = client.graph().list_keys()
assert result == ["G", "X"]

Expand Down