Skip to content

Conversation

lucacillario
Copy link
Contributor

Pull Request check-list

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Added documentation to explain how works Redis retry

Closes #2166

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Base: 92.22% // Head: 92.20% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (90e9abf) compared to base (fa45fb1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2456      +/-   ##
==========================================
- Coverage   92.22%   92.20%   -0.03%     
==========================================
  Files         113      113              
  Lines       29239    29239              
==========================================
- Hits        26967    26960       -7     
- Misses       2272     2279       +7     
Impacted Files Coverage Δ
tests/test_cluster.py 96.75% <0.00%> (-0.34%) ⬇️
tests/test_asyncio/test_cluster.py 97.36% <0.00%> (-0.13%) ⬇️
tests/test_asyncio/test_pubsub.py 99.53% <0.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim chayim requested a review from nermiller November 15, 2022 12:53
@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Nov 15, 2022
@chayim
Copy link
Contributor

chayim commented Nov 15, 2022

@lucacillario This is awesome. Thank you so much. We have such a great community!

@nermiller Mind having a read? I think we can get this into things quickly!

@dvora-h Ignore CI.. Looks like yet again, the pypi issues are back :(

@lucacillario
Copy link
Contributor Author

lucacillario commented Nov 15, 2022

Glad to help @chayim! 😄 By the way, writing the documentation for Redis Cluster, i noticed that although you can pass retry_on_error to RedisCluster's constructor it basically has no effect, because the execute_command method uses:

connection.send_command(*args)

instead of:

connection.retry.call_with_retry(blablabla)

Is there a reason for not using call_with_retry?

Copy link
Contributor

@nermiller nermiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks, @chayim.

lucacillario and others added 8 commits November 20, 2022 11:36
Co-authored-by: Nermina Miller <[email protected]>
Co-authored-by: Nermina Miller <[email protected]>
Co-authored-by: Nermina Miller <[email protected]>
Co-authored-by: Nermina Miller <[email protected]>
Co-authored-by: Nermina Miller <[email protected]>
Co-authored-by: Nermina Miller <[email protected]>
Co-authored-by: Nermina Miller <[email protected]>
Co-authored-by: Nermina Miller <[email protected]>
@dvora-h dvora-h merged commit af44021 into redis:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation to explain how works Redis retry
5 participants