-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Retry documentation. (#2166) #2456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 92.22% // Head: 92.20% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2456 +/- ##
==========================================
- Coverage 92.22% 92.20% -0.03%
==========================================
Files 113 113
Lines 29239 29239
==========================================
- Hits 26967 26960 -7
- Misses 2272 2279 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@lucacillario This is awesome. Thank you so much. We have such a great community! @nermiller Mind having a read? I think we can get this into things quickly! @dvora-h Ignore CI.. Looks like yet again, the pypi issues are back :( |
Glad to help @chayim! 😄 By the way, writing the documentation for Redis Cluster, i noticed that although you can pass connection.send_command(*args) instead of: connection.retry.call_with_retry(blablabla) Is there a reason for not using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nitpicks, @chayim.
Co-authored-by: Nermina Miller <[email protected]>
Co-authored-by: Nermina Miller <[email protected]>
Co-authored-by: Nermina Miller <[email protected]>
Co-authored-by: Nermina Miller <[email protected]>
Co-authored-by: Nermina Miller <[email protected]>
Co-authored-by: Nermina Miller <[email protected]>
Co-authored-by: Nermina Miller <[email protected]>
Co-authored-by: Nermina Miller <[email protected]>
Pull Request check-list
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Added documentation to explain how works Redis retry
Closes #2166