Skip to content

Fix for lpop and rpop return typing #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Fix for lpop and rpop return typing #2590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions redis/commands/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2667,7 +2667,11 @@ def llen(self, name: str) -> Union[Awaitable[int], int]:
"""
return self.execute_command("LLEN", name)

def lpop(self, name: str, count: Optional[int] = None) -> Union[str, List, None]:
def lpop(
self,
name: str,
count: Optional[int] = None,
) -> Union[Awaitable[Union[str, List, None]], Union[str, List, None]]:
"""
Removes and returns the first elements of the list ``name``.

Expand Down Expand Up @@ -2744,7 +2748,11 @@ def ltrim(self, name: str, start: int, end: int) -> Union[Awaitable[str], str]:
"""
return self.execute_command("LTRIM", name, start, end)

def rpop(self, name: str, count: Optional[int] = None) -> Union[str, List, None]:
def rpop(
self,
name: str,
count: Optional[int] = None,
) -> Union[Awaitable[Union[str, List, None]], Union[str, List, None]]:
"""
Removes and returns the last elements of the list ``name``.

Expand Down