-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fixing errors reported by mypy in search module files - query.py, commands.py and aggregation.py. #3666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ad1f6ea
to
4a284e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes mypy type checking errors in the Redis search module by improving type annotations and correcting type inconsistencies across query.py, commands.py, and aggregation.py files.
- Added missing type imports and improved type annotations for better static type checking
- Fixed parameter type definitions to use proper Optional syntax instead of Union with None
- Corrected return type annotations and variable type declarations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
redis/commands/search/query.py | Enhanced type annotations, fixed return types, and improved parameter type definitions |
redis/commands/search/commands.py | Replaced Union with None syntax with proper Optional type annotations |
redis/commands/search/aggregation.py | Added comprehensive type annotations and fixed method signatures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bc12bc4
to
b7074a7
Compare
…cuted through search pipelines
30cb5b8
to
e577cda
Compare
…mands.py and aggregation.py. (#3666)
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fixing errors reported by mypy.