Skip to content

✨ Add BLMPOP #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions lib/redis/commands/lists.rb
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,34 @@ def brpoplpush(source, destination, timeout: 0)
send_blocking_command(command, timeout)
end

# Pops one or more elements from the first non-empty list key from the list
# of provided key names. If lists are empty, blocks until timeout has passed.
#
# @example Popping a element
# redis.blmpop(1.0, 'list')
# #=> ['list', ['a']]
# @example With count option
# redis.blmpop(1.0, 'list', count: 2)
# #=> ['list', ['a', 'b']]
#
# @params timeout [Float] a float value specifying the maximum number of seconds to block) elapses.
# A timeout of zero can be used to block indefinitely.
# @params key [String, Array<String>] one or more keys with lists
# @params modifier [String]
# - when `"LEFT"` - the elements popped are those from the left of the list
# - when `"RIGHT"` - the elements popped are those from the right of the list
# @params count [Integer] a number of elements to pop
#
# @return [Array<String, Array<String, Float>>] list of popped elements or nil
def blmpop(timeout, *keys, modifier: "LEFT", count: nil)
raise ArgumentError, "Pick either LEFT or RIGHT" unless modifier == "LEFT" || modifier == "RIGHT"

args = [:lmpop, keys.size, *keys, modifier]
args << "COUNT" << Integer(count) if count

send_blocking_command(args, timeout)
end

# Pops one or more elements from the first non-empty list key from the list
# of provided key names.
#
Expand Down
9 changes: 8 additions & 1 deletion lib/redis/distributed.rb
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,14 @@ def ltrim(key, start, stop)
node_for(key).ltrim(key, start, stop)
end

# Iterate over keys, removing elements from the first non list set found.
# Iterate over keys, blocking and removing elements from the first non empty liist found.
def blmpop(timeout, *keys, modifier: "LEFT", count: nil)
ensure_same_node(:blmpop, keys) do |node|
node.blmpop(timeout, *keys, modifier: modifier, count: count)
end
end

# Iterate over keys, removing elements from the first non list found.
def lmpop(*keys, modifier: "LEFT", count: nil)
ensure_same_node(:lmpop, keys) do |node|
node.lmpop(*keys, modifier: modifier, count: count)
Expand Down
13 changes: 13 additions & 0 deletions test/lint/lists.rb
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,19 @@ def test_variadic_rpoplpush_expand
assert_equal 'c', redis.rpoplpush('{1}foo', '{1}bar')
end

def test_blmpop
target_version('7.0') do
assert_nil r.blmpop(1.0, '{1}foo')

r.lpush('{1}foo', %w[a b c d e f g])
assert_equal ['{1}foo', ['g']], r.blmpop(1.0, '{1}foo')
assert_equal ['{1}foo', ['f', 'e']], r.blmpop(1.0, '{1}foo', count: 2)

r.lpush('{1}foo2', %w[a b])
assert_equal ['{1}foo', ['a']], r.blmpop(1.0, '{1}foo', '{1}foo2', modifier: "RIGHT")
end
end

def test_lmpop
target_version('7.0') do
assert_nil r.lmpop('{1}foo')
Expand Down