Add :with_score option to zrank and zrevrank #1300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, it's just missing the server version checks in the test so it doesn't fail CI against older servers. See the |
|
Found it thanks. Should be fixed. |
byroot
force-pushed
the
hh/zrevrank-withscore
branch
from
26c70af to
fb70908
Compare
This was referenced May 10, 2025
sds
pushed a commit
to sds/mock_redis
that referenced
this pull request
May 16, 2025
Fix for #323 #324 with specs fixed. Problem was that the arity of some methods changed from `redis 5.3.0` to `redis 5.4.0` due to redis/redis-rb#1300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option was introduced with Redis 7.2.0