Skip to content

Add security supported versions to testing matrix #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

s01ipsist
Copy link
Contributor

The Github Actions testing matrix currently only runs against versions <=7.0.

As per https://endoflife.date/redis, the security supported versions are 7.2, 7.4 and 8.0.
8.2 also came out yesterday: https://github.com/redis/redis/releases

This leaves versions <=7.0 in the test matrix, even though they are no longer supported upstream.

@s01ipsist
Copy link
Contributor Author

https://github.com/s01ipsist/redis-rb/actions/runs/16739960872/job/47386180705

Both 8.0 and 8.2 have a failure on the geopos function that appears to be around decimal precision.

  1) Failure:
TestCommandsGeo#test_geopos [test/redis/commands_on_geo_test.rb:64]:
--- expected
+++ actual
@@ -1 +1 @@
-[["15.08726745843887329", "37.50266842333162032"]]
+[["15.087267458438873", "37.50266842333162"]]


  2) Failure:
TestCommandsGeo#test_geopos_nonexistant_location [test/redis/commands_on_geo_test.rb:75]:
--- expected
+++ actual
@@ -1 +1 @@
-[nil, ["15.08726745843887329", "37.50266842333162032"]]
+[nil, ["15.087267458438873", "37.50266842333162"]]

Any preference on how to handle this?

@byroot
Copy link
Collaborator

byroot commented Aug 5, 2025

Any preference on how to handle this?

You can check the server version:

if version >= "8.2"
  assert ...
else
  assert ...
end

Might be worth renaming version in server_version though.

@s01ipsist
Copy link
Contributor Author

You can check the server version:

I've added conditional logic for the expected values for Palermo and Catania. Let me know if this works for you

@byroot
Copy link
Collaborator

byroot commented Aug 5, 2025

Works for me. Please just clean your git history.

@s01ipsist
Copy link
Contributor Author

Ok... Not quite clear on that request. Do you mean like what a squash merge would do?

@s01ipsist s01ipsist force-pushed the update_testing_matrix branch from 6750b17 to 80dd36b Compare August 5, 2025 09:27
@byroot byroot merged commit 1d96f77 into redis:master Aug 5, 2025
26 checks passed
@s01ipsist s01ipsist deleted the update_testing_matrix branch August 5, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants