Avoid Fixnum deprecation warning on Ruby trunk #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance we can merge this item? |
|
Let me grab 2.4-rc1 and see for myself. Otherwise I don't see why not. |
|
Any chance of getting a release of this? |
|
Hm, we should probably get 4.0 out of the door. |
|
Would love to see v3.3.3 with this change released! 😄 |
|
Just to echo the sentiments here in case this got forgotten in the holiday shuffle, I think a tiny patch release just so we can silence the deprecation warnings would be great! |
|
Just so everyone knows, it looks like 3.3.3 contains the above commit. It's not reflected in the changelog for 3.3.3, but I just submitted a PR to add it ;) |
|
@georgemillo yep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.