feat: separate light and dark themes (help needed) #378
Conversation
ac615223s5
changed the title
ac615223s5
force-pushed
the
separate-theme
branch
from
cc1d548 to
604aef1
Compare
|
Will this be merged soon? I'm excited for it! |
| pub theme: String, | ||
| pub theme_light: String, | ||
| #[revision(start = 1)] | ||
| pub theme_dark: String, |
There was a problem hiding this comment.
I'm using the revision library here to specifically allow for reverse compatibility of parsed Preferences (that's the test that is currently failing). Try leaving theme but making its derive tag #[revision(start = 1, end = 2)], then the new light and dark ones #[revision(start = 2)] (and changing revision to 2 at the top of the Preferences struct). Once you get the tests passing, go to Redlib in an incognito browser and export a new Preferences string (with a revision of 2) and add it to the KNOWN_GOOD_CONFIGS array.
| #[serde(rename = "REDLIB_DEFAULT_THEME")] | ||
| #[serde(alias = "LIBREDDIT_DEFAULT_THEME")] | ||
| pub(crate) default_theme: Option<String>, |
There was a problem hiding this comment.
Is there any way we can preserve this behavior so someone with the REDLIB_DEFAULT_THEME env var set doesn't have to change it? Possibly by giving default_theme_light and default_theme_dark an alias of REDLIB_DEFAULT_THEME in order to make it the default across both?
ac615223s5
force-pushed
the
separate-theme
branch
from
ee87f6b to
482e698
Compare
|
I made the changes but it doesn't compile anymore ( |
|
Bump, could anyone help us out here? |
ac615223s5
changed the title
closes #368
closes #299
closes #289