Skip to content
This repository was archived by the owner on Dec 2, 2022. It is now read-only.

Alternative fix for #194 #204

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Alternative fix for #194 #204

merged 2 commits into from
Mar 18, 2021

Conversation

kprovance
Copy link
Member

No description provided.

@dovy dovy merged commit 874190f into reduxframework:master Mar 18, 2021
@lazardanlucian
Copy link

lazardanlucian commented Mar 18, 2021

you might not understand me, but your plugin arbitrarily parses (requires) any file in that directory, that is not normal, since if the file that is 'required' is broken,

require is identical to include except upon failure it will also produce a fatal E_COMPILE_ERROR level error. In other words, it will halt the script whereas include only emits a warning (E_WARNING) which allows the script to continue.

so, do whatever you want, require all the files if that's what you want, but at least understand what kind of errors that can produce in specific cases :

the file is broken
the code in the file is broken
etc

that's why i suggested using include_once instead of require_once,
you can't really need a file you don't know how it's named
at best you might want to have it, so you include it, not require it,

@dovy and @kprovance do you fail to see why require_once(any file) is a bad idea ?
you literally have no idea what files could potentially get in that directory but you require them all....

kprovance added a commit to svl-studios/redux-framework-4 that referenced this pull request Apr 19, 2021
Merge pull request reduxframework#204 from svl-studios/master
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants