Skip to content

Port additional React-Redux TS typetests from DefinitelyTyped #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markerikson opened this issue Dec 21, 2021 · 1 comment · Fixed by #1855
Closed

Port additional React-Redux TS typetests from DefinitelyTyped #1854

markerikson opened this issue Dec 21, 2021 · 1 comment · Fixed by #1855
Milestone

Comments

@markerikson
Copy link
Contributor

We copied over a bunch of typetests for React-Redux as part of the TS conversion, which are currently here:

React-Redux: test/typetests/react-redux-typetests.tsx

However, I was just comparing that file with the typetests that are currently in DefinitelyTyped, and there's a big difference. Our current file is only around 500 lines, and the DT file is about 1600 lines:

DefinitelyTyped: react-redux/react-redux-typetests.tsx

We should review the DT typetest file and port over as much as possible, to ensure that the types we've ported and updated are thoroughly covered and don't break existing code. Also might be good to split the typetests into separate files (at a minimum one each for connect, useDispatch, and useSelector - maybe even further?) so it's easier to find a given section.

@markerikson markerikson added this to the 8.0 milestone Dec 21, 2021
@markerikson
Copy link
Contributor Author

Might as well tackle this myself for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant