You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, I was just comparing that file with the typetests that are currently in DefinitelyTyped, and there's a big difference. Our current file is only around 500 lines, and the DT file is about 1600 lines:
We should review the DT typetest file and port over as much as possible, to ensure that the types we've ported and updated are thoroughly covered and don't break existing code. Also might be good to split the typetests into separate files (at a minimum one each for connect, useDispatch, and useSelector - maybe even further?) so it's easier to find a given section.
The text was updated successfully, but these errors were encountered:
We copied over a bunch of typetests for React-Redux as part of the TS conversion, which are currently here:
React-Redux:
test/typetests/react-redux-typetests.tsx
However, I was just comparing that file with the typetests that are currently in DefinitelyTyped, and there's a big difference. Our current file is only around 500 lines, and the DT file is about 1600 lines:
DefinitelyTyped:
react-redux/react-redux-typetests.tsx
We should review the DT typetest file and port over as much as possible, to ensure that the types we've ported and updated are thoroughly covered and don't break existing code. Also might be good to split the typetests into separate files (at a minimum one each for
connect
,useDispatch
, anduseSelector
- maybe even further?) so it's easier to find a given section.The text was updated successfully, but these errors were encountered: