Skip to content

reopening #92 Nested connected components throwing Warning: setState(...) #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Agamennon opened this issue Sep 6, 2015 · 8 comments
Closed

Comments

@Agamennon
Copy link

Made an example repo, details to help understand the example in the repository readme.

Very grateful if this could be looked into

@alexkuz
Copy link

alexkuz commented Sep 6, 2015

@Agamennon It's not working for me :(
First, there is a link to a local repo in package.json:

"redux-tiny-router": "file:../redux-tiny-router",

I've installed it from npm, but didn't manage to make it work (via npm start) - seems like /build/bundle.js redirects to index page.

@Agamennon
Copy link
Author

repo fixed., please try again

@gaearon
Copy link
Contributor

gaearon commented Sep 6, 2015

FYI, you can reopen existing issues:

screen shot 2015-09-07 at 01 29 15

@Agamennon
Copy link
Author

@gaearon , i don't think i can, the Reopen Issue button does not show up for me.

@gaearon
Copy link
Contributor

gaearon commented Sep 6, 2015

Oh, I didn't realize this was the case.
Looking into your example now.

@gaearon
Copy link
Contributor

gaearon commented Sep 6, 2015

There is indeed a bug: if you have unsubscribed during a dispatch, we should ignore the change event.
I'll fix the code shortly.
Thanks for reporting.

@Agamennon
Copy link
Author

@gaearon awsome, thank you!

@gaearon
Copy link
Contributor

gaearon commented Sep 6, 2015

Should be fixed in 2.1.1 via #96.

@gaearon gaearon closed this as completed Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants