Skip to content

Docs: overview of selector functions #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

zsid
Copy link

@zsid zsid commented Oct 29, 2018

What does this PR do

  • Adds a section about selectors

Summary of the Changes

  • Adds a sub-section about selectors in Using React-Redux section

Questions

  • I am trying to find how to run the docs and see how they look on the page but I was unable to find it. What is the best way to do it?

@netlify
Copy link

netlify bot commented Oct 29, 2018

Deploy preview for react-redux-docs ready!

Built with commit 03f8065

https://deploy-preview-1068--react-redux-docs.netlify.com

@zsid zsid force-pushed the docs/selectors branch 2 times, most recently from 69fff42 to 731daef Compare October 29, 2018 19:21
@markerikson
Copy link
Contributor

@zsid : you should be able to run a local docs live preview server - see the instructions in $REPO/website/README.md .

Now that the PR has been pushed up, you can also view the Netlify preview build at https://deploy-preview-1068--react-redux-docs.netlify.com/ .

@markerikson
Copy link
Contributor

I'll try to look this over in the next couple days. Thanks!

@zsid
Copy link
Author

zsid commented Oct 29, 2018

Great, thx Mark. No rush 😄

@JoshAddington
Copy link

If the conflicts in this PR are fixed, could this be merged soon? I was trying to find info in the docs about using selectors to send to a colleague, but most of the info that's applicable is in this PR.

@markerikson
Copy link
Contributor

@JoshAddington : I think I had reservations on how the wording on this turned out, but it's been long enough I don't remember the specifics.

Overall, this is based off my post at https://blog.isquaredsoftware.com/2017/12/idiomatic-redux-using-reselect-selectors/ - you might want to use that as the baseline reference atm.

I'll see if I can swing back around and re-evaluate this PR soon, but my attention is mostly focused on React-Redux v7 atm.

@markerikson
Copy link
Contributor

I'm going to close this. It's not bad, but things somehow got rephrased from my original post in ways that feel a bit off to me.

In addition, we need to rethink our docs on this based on how we're working on the hooks APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants