-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Docs: overview of selector functions #1068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for react-redux-docs ready! Built with commit 03f8065 |
69fff42
to
731daef
Compare
@zsid : you should be able to run a local docs live preview server - see the instructions in Now that the PR has been pushed up, you can also view the Netlify preview build at https://deploy-preview-1068--react-redux-docs.netlify.com/ . |
I'll try to look this over in the next couple days. Thanks! |
Great, thx Mark. No rush 😄 |
If the conflicts in this PR are fixed, could this be merged soon? I was trying to find info in the docs about using selectors to send to a colleague, but most of the info that's applicable is in this PR. |
@JoshAddington : I think I had reservations on how the wording on this turned out, but it's been long enough I don't remember the specifics. Overall, this is based off my post at https://blog.isquaredsoftware.com/2017/12/idiomatic-redux-using-reselect-selectors/ - you might want to use that as the baseline reference atm. I'll see if I can swing back around and re-evaluate this PR soon, but my attention is mostly focused on React-Redux v7 atm. |
I'm going to close this. It's not bad, but things somehow got rephrased from my original post in ways that feel a bit off to me. In addition, we need to rethink our docs on this based on how we're working on the hooks APIs. |
What does this PR do
Summary of the Changes
Using React-Redux
sectionQuestions