Skip to content

Rethrowing original errors thrown in selector functions #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2019
Merged

Rethrowing original errors thrown in selector functions #1474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9706cc6
Added optional stacktrace to errors thrown from selector functions
r3dm1ke Nov 24, 2019
f310d64
Rethrowing original errors from selector functions
r3dm1ke Nov 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/hooks/useSelector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,11 @@ function useSelectorWithStoreAndSubscription(
selectedState = latestSelectedState.current
}
} catch (err) {
let errorMessage = `An error occurred while selecting the store state: ${err.message}.`

if (latestSubscriptionCallbackError.current) {
errorMessage += `\nThe error may be correlated with this previous error:\n${latestSubscriptionCallbackError.current.stack}\n\nOriginal stack trace:`
err.message += `\nThe error may be correlated with this previous error:\n${latestSubscriptionCallbackError.current.stack}\n\n`
}

throw new Error(errorMessage)
throw err
}

useIsomorphicLayoutEffect(() => {
Expand Down