Rewrite Subscription as a closure factory for byte shaving #1755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 20a2394:
|
|
Size Change: -755 B (3%) Total Size: 19.4 kB
|
|
✔️ Deploy Preview for react-redux-docs ready! 🔨 Explore the source changes: 20a2394 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/60e3b1db633fd50007e0eeb7 😎 Browse the preview: https://deploy-preview-1755--react-redux-docs.netlify.app |
markerikson
force-pushed
the
feature/subscription-size
branch
2 times, most recently
from
aec28bf to
dc2b380
Compare
markerikson
force-pushed
the
feature/subscription-size
branch
from
dc2b380 to
20a2394
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Subscriptionclass to be a closure factory instead, which should shrink minified size by about 300 bytesbindActionCreatorsback to the simpler version we had when we copied it over to save a few more bytesThe
Subscriptionclass is one of the two biggest pieces when you importuseSelector, the other being theuseSelectorhook itself. I noticed that when we convertedSubscriptionto TS, we added some uses of the?.optional chaining operator, but each of those gets compiled into several null/undefined checks.I went to change the optional chaining back to simple
ifclauses instead, but then realized that if I switched this to be a closure factory, I could drop all the uses ofthisas a bonus.We can apply the same changes over in the 7.2 line as well.