AsyncAction should accept ThunkAction or Action #149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overwriting default redux Dispatch type should be able to handle both the type for ThunkAction and the Type for the Redux Dispatch Fix related to this issue: #82 Example of a fix with a failing test: https://github.com/codebandits/typescript-react-starter/blob/master/src/main/actions/__test__/actions.test.ts#L8-L12
|
Thanks @rodolfo2488 for the help! |
unstubbable
suggested changes
Aug 18, 2017
| @@ -6,7 +6,7 @@ export type ThunkAction<R, S, E> = (dispatch: Dispatch<S>, getState: () => S, | |||
|
|
|||
| declare module "redux" { | |||
| export interface Dispatch<S> { | |||
| <R, E>(asyncAction: ThunkAction<R, S, E>): R; | |||
| <R, E>(asyncAction: ThunkAction<R, S, E> | S): R; | |||
There was a problem hiding this comment.
Why would asyncAction have the type of the state (i.e. S)?
There was a problem hiding this comment.
Yep, shouldn't this be Action. From import { Action } from 'redux'?
|
This has been superseded by some other updates to the typings. If you want to revisit this, I can reopen it for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overwriting default redux Dispatch type should be able to handle both the type for ThunkAction and the Type for the Redux Dispatch
Fix related to this issue:
#82
Example of a fix with a failing test:
https://github.com/codebandits/typescript-react-starter/blob/master/src/main/actions/__test__/actions.test.ts#L8-L12