Skip to content

Remove unnecessary browserify config in package.json and envify dependency #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

dariocravero
Copy link
Contributor

This PR removes the browserify config in package.json and the dependency to envify (#88) which doesn't seem to be used.

Darío Javier Cravero added 2 commits June 16, 2015 23:15
@dariocravero
Copy link
Contributor Author

(let me clean the commit history before merging it in)

@cdevienne
Copy link

Unless I am mistaken, the browserify+envify config is useful.

In my case, when I assemble my app with browserify, even if I setup envify in my own project, the substitution is not done in the redux source. The result is that the dev version of redux, and not the production one, is enabled in my application.

To solve this, the only solution I found so far is to revert this patch on my locally installed redux.

Could you consider re-add the option ? The extra dependency looks not a big issue since react already pulls it for the same reason.

Also, you may want to use loose-envify instead of envify, because it is much faster.

@gaearon
Copy link
Contributor

gaearon commented Jan 29, 2016

I totally forgot about this PR! We have re-added the config since then. Now I understand how Browserify works a bit better :-). Apparently many people don't run envify with a global flag in their project and this is why they used to get development build instead of production build of Redux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants