Skip to content

Use destructuring for one-line var swapping #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mAAdhaTTah
Copy link

This is just a stylistic thing, but this can be simplified to one line. More info (#4 in the list). Up to you if you want it.

@gaearon
Copy link
Contributor

gaearon commented Jun 11, 2016

This doesn’t seem to pass lint. In general, we prefer to avoid stylistic changes because they don’t bring much benefit, and sometimes introduce subtle errors. But thanks for the PR!

@gaearon gaearon closed this Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants