Allow to pass custom dispatcher to Root component #33
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,12 +13,19 @@ export default class ReduxRoot { | |||
| }; | |||
|
|
|||
| constructor(props) { | |||
| this.dispatcher = createDispatcher(); | |||
| this.dispatcher.receiveStores(props.stores); | |||
| this.dispatcher = props.dispatcher || createDispatcher(); | |||
There was a problem hiding this comment.
Couldn't createDispatcher() be called in static defaultProps?
There was a problem hiding this comment.
It isn't good for two reasons:
- Dispatcher from defaultProps will be shared between all Root instances.
- It will be created even if we don't use it.
|
@gaearon what are you think? |
6 tasks
|
Closed via #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be helpful for #32