Update docs to describe current version of Redux-ORM #3400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for redux-docs ready! Built with commit b65721c |
|
Cool, thanks! |
fgallinari
reviewed
Apr 22, 2019
| // Define a foreign key relation - one Post can have many Comments, | ||
| // at a field named "comments" | ||
| postId: fk({ | ||
| to: 'Comment', |
There was a problem hiding this comment.
There is an error here that drove me nuts.
It should be 'Post' instead of 'Comment'.
There was a problem hiding this comment.
Yep, my bad! Opened a PR with a fix.
haveyaseen
added a commit
to haveyaseen/redux
that referenced
this pull request
Apr 23, 2019
Also explain options using comments See reduxjs#3400 (review)
timdorr
pushed a commit
that referenced
this pull request
Apr 23, 2019
* Fix Redux-ORM related model name Also explain options using comments See #3400 (review) * Remove superfluous comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, this is a requested update to the state management section describing Redux-ORM. It's actually been outdated since version 0.9 (we're at v0.13.2 now). We also moved the repository to a GitHub organization.
To prevent confusion, I simplified some payload properties and removed the part about "queued updates" which is an implementation detail regarding performance. The paragraph that I added in the end is supposed to make the benefits of managed relationships a bit more obvious.