-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[Docs: Rephrase] Explain correctly what a thunk is #3973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs: Rephrase] Explain correctly what a thunk is #3973
Conversation
eebff6c
to
de17019
Compare
✔️ Deploy preview for redux-docs ready! 🔨 Explore the source changes: eebff6c 🔍 Inspect the deploy logs: https://app.netlify.com/sites/redux-docs/deploys/5fdd233fd8192300087de22f 😎 Browse the preview: https://deploy-preview-3973--redux-docs.netlify.app |
✔️ Deploy preview for redux-docs ready! 🔨 Explore the source changes: de17019 🔍 Inspect the deploy logs: https://app.netlify.com/sites/redux-docs/deploys/5fdd239e65229b000853ad34 😎 Browse the preview: https://deploy-preview-3973--redux-docs.netlify.app |
I don't believe the current copy needs any changes. Per MDN, |
@msutkowski Thanks for your remark. I ll close the PR in this case. Just before doing so, I just mention here how redux-thunk documentation explains what a thunk is : |
This seems fine to me. Thanks! |
Former-commit-id: ec491b9
name: 📝 Documentation Fix
about: Fixing a problem in an existing docs page
Checklist
What docs page needs to be fixed?
What is the problem?
In the paragraph Usage with Redux Thunk, the concept of thunk is wrongly explained.
This definition corresponds to a thunk action creator but not to a thunk.
What changes does this PR make to fix the problem?
Explain correctly what a thunk is.