Skip to content

[Docs: Rephrase] Explain correctly what a thunk is #3973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Sakai-san
Copy link
Contributor

@Sakai-san Sakai-san commented Dec 18, 2020


name: 📝 Documentation Fix
about: Fixing a problem in an existing docs page

Checklist

  • Is there an existing issue for this PR?
  • Have the files been linted and formatted?

What docs page needs to be fixed?

  • Section: Recipes
  • Page: Usage With TypeScript

What is the problem?

In the paragraph Usage with Redux Thunk, the concept of thunk is wrongly explained.

A thunk is a function that returns another function that takes parameters dispatch and getState.

This definition corresponds to a thunk action creator but not to a thunk.

What changes does this PR make to fix the problem?

Explain correctly what a thunk is.

@Sakai-san Sakai-san force-pushed the Docs-Rephrase-thunk-explination-recipes-section branch from eebff6c to de17019 Compare December 18, 2020 21:48
@netlify
Copy link

netlify bot commented Dec 18, 2020

✔️ Deploy preview for redux-docs ready!

🔨 Explore the source changes: eebff6c

🔍 Inspect the deploy logs: https://app.netlify.com/sites/redux-docs/deploys/5fdd233fd8192300087de22f

😎 Browse the preview: https://deploy-preview-3973--redux-docs.netlify.app

@netlify
Copy link

netlify bot commented Dec 18, 2020

✔️ Deploy preview for redux-docs ready!

🔨 Explore the source changes: de17019

🔍 Inspect the deploy logs: https://app.netlify.com/sites/redux-docs/deploys/5fdd239e65229b000853ad34

😎 Browse the preview: https://deploy-preview-3973--redux-docs.netlify.app

@msutkowski
Copy link
Member

I don't believe the current copy needs any changes. Per MDN, Any unit of code that can be evaluated to a value is an expression - which would be inaccurate in this instance, as a thunk doesn't necessarily evaluate to anything.

@Sakai-san
Copy link
Contributor Author

I don't believe the current copy needs any changes. Per MDN, Any unit of code that can be evaluated to a value is an expression - which would be inaccurate in this instance, as a thunk doesn't necessarily evaluate to anything.

@msutkowski Thanks for your remark. I ll close the PR in this case. Just before doing so, I just mention here how redux-thunk documentation explains what a thunk is :

Screenshot 2020-12-19 at 00 58 52

@timdorr
Copy link
Member

timdorr commented Dec 19, 2020

This seems fine to me. Thanks!

@timdorr timdorr merged commit aa67956 into reduxjs:master Dec 19, 2020
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Former-commit-id: ec491b9
Former-commit-id: 4cb85c6
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Former-commit-id: ec491b9
Former-commit-id: 4cb85c6
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Former-commit-id: ec491b9
Former-commit-id: 4cb85c6
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Former-commit-id: ec491b9
Former-commit-id: 4cb85c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants