Skip to content

Clarify when it's necessary to copy selectors #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2016

Conversation

courthead
Copy link
Contributor

Previously, it was unclear for people skimming the docs that the advice found in the Sharing Selectors Across Multiple Components section only applies for those trying to solve the specific problem mentioned in the previous section. As a result, I'm sure some people were padding private copies of selectors to different components even in situations where they didn't need to. This makes the documentation more clear.

Previously, it was unclear for people skimming the docs that the advice found in the `Sharing Selectors Across Multiple Components` section only applies for those trying to solve the specific problem mentioned in the previous section. As a result, I'm sure some people were padding private copies of selectors to different components even in situations where they didn't need to. This makes the documentation more clear.
@codecov-io
Copy link

Current coverage is 100.00%

Merging #107 into master will not affect coverage as of 79e8f9b

@@            master    #107   diff @@
======================================
  Files            1       1       
  Stmts           42      42       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit             42      42       
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of 79e8f9b

Powered by Codecov. Updated on successful CI builds.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 29891c7 on courthead:patch-1 into 865f7de on reactjs:master.

@ellbee ellbee merged commit 6ce2547 into reduxjs:master Apr 5, 2016
@ellbee
Copy link
Collaborator

ellbee commented Apr 5, 2016

Thank you!

luqmaan pushed a commit to luqmaan/reselect that referenced this pull request Apr 25, 2016
Fix link broken by reduxjs#107
@luqmaan luqmaan mentioned this pull request Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants