Skip to content

Add custom message with current time in console when the user exits an app #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

quietpigeon
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

@quietpigeon
Copy link
Contributor Author

closes #1261

@quietpigeon quietpigeon changed the title Display custom message with current time in console when the user exits an app Add custom message with current time in console when the user exits an app Jul 15, 2023
@masenf
Copy link
Collaborator

masenf commented Jul 17, 2023

@picklelo check out the integration test failures on this PR. Looks like dnspython released 2.4.0 yesterday which dropped <3.8 support and seems to have broken the tests by depending on an new version of httpcore. I haven't investigated yet, but FYI.

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving to see if the integration tests can pass now

@picklelo picklelo merged commit d6b1915 into reflex-dev:main Jul 17, 2023
@quietpigeon quietpigeon deleted the custom-exit-message branch July 19, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants