-
Notifications
You must be signed in to change notification settings - Fork 110
[feat] Add support for marking tests as expected failures #3481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
7bbb18a
to
0d5b5e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
.
8cb57af
to
489e3b0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3481 +/- ##
============================================
- Coverage 91.13% 67.14% -24.00%
============================================
Files 62 60 -2
Lines 13132 13167 +35
============================================
- Hits 11968 8841 -3127
- Misses 1164 4326 +3162 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The main elements introduced by this PR are:
@xfail
decorator to mark a test as an expected sanity failure.xfail()
builtin to mark reference tuples as expected performance failures.Two new test states are introduced which are also logged:
XFAIL
for expected failures andXPASS
for unexpected passes.Design-wise the concept is the same as the one explained in #2378.
Implementation-wise there are two major changes:
reference_bounds()
is introduced which is used to validate and calculate the absolute lower/upper bounds. This used to be internal toassert_reference()
and now it's made public (maybe the docs there need a slight reorganization).pass
,fail
,xpass
orxfail
.For more details on how feature works macroscopically check the tutorial and the reference docs.
Closes #2378.