Skip to content

Attaching some error handling #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsdf opened this issue Jul 31, 2014 · 3 comments
Closed

Attaching some error handling #151

jsdf opened this issue Jul 31, 2014 · 3 comments

Comments

@jsdf
Copy link

jsdf commented Jul 31, 2014

Where can I attach some error handling?

Any errors which occur during the initial render of a view which I've just navigated to end up getting caught and rethrown by Routes.statics.handleAsyncError.

This alerts me to the error (which is okay in development) but I can't see where I might attach my own handling to it.

@mjackson
Copy link
Member

I've got some better error handling going on the routes-props branch, but there are a few failing tests to work out still. I'm fairly sure that nothing is wrong with the code, just something up with our test harness... :/

Anyway, once that's merged you'll be able to do stuff like this:

<Routes onTransitionError={myErrorHandler}>
  ...
</Routes>

@jsdf
Copy link
Author

jsdf commented Aug 4, 2014

Cool, that's exactly what I was looking for.

@ryanflorence
Copy link
Member

closing, please follow #152

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
brophdawg11 pushed a commit that referenced this issue Mar 27, 2024
- adds `useTransition` for finer grained control over pending indicators and optimistic UI
- adds "submission keys" to get the transition for a specific form's submissions rather than the global transition, allowing apps to create complex UIs with a lot of mutations happening at the same time
- adds support for concurrent form submissions (#151)
- adds route module `shouldReload` to optimize which routes should reload on form submission reloads or search param changes (#181, #175)
- reloads data when links to the current url are clicked (#128)
- provides state change updates on navigations (#54-ish)
- fixed issues with submitting a form multiple times quickly that completely broke the app before
- is mostly Remix agnostic, so we should be able to bring it over to React Router without to much headache

Closes #151, #181, #175, #128, #54, #208
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants