Skip to content

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Jun 3, 2025

I'm sure people from the wider @e18e ecosystem cleanup (like @43081j, @benmccann & @outslept) will be very happy to see these kind of changes as well

@MichaelDeBoey MichaelDeBoey added dependencies Pull requests that update a dependency file pkg:create-react-router labels Jun 3, 2025
Copy link

changeset-bot bot commented Jun 3, 2025

⚠️ No Changeset found

Latest commit: c580c96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the remove-recursive-readdir-usage branch from 6007529 to 5da38b7 Compare June 4, 2025 12:02
@MichaelDeBoey MichaelDeBoey requested a review from 43081j June 4, 2025 12:06
@43081j
Copy link
Contributor

43081j commented Jun 4, 2025

(sorry for the re-approval, was trying to close off my old review comments but it didn't work 😅 )

the filter change did work in the end it seems 👍

@MichaelDeBoey MichaelDeBoey force-pushed the remove-recursive-readdir-usage branch 4 times, most recently from 4321b12 to 290488b Compare June 5, 2025 23:00
@MichaelDeBoey MichaelDeBoey force-pushed the remove-recursive-readdir-usage branch from 290488b to c580c96 Compare June 6, 2025 00:08
@timdorr
Copy link
Member

timdorr commented Jun 6, 2025

Looks pretty similar to #13736 in scope. Thanks for getting this cleaned up!

@timdorr timdorr merged commit d0bf252 into remix-run:dev Jun 6, 2025
8 checks passed
@MichaelDeBoey MichaelDeBoey deleted the remove-recursive-readdir-usage branch June 6, 2025 20:16
Copy link
Contributor

🤖 Hello there,

We just published version 7.6.3-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.6.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed dependencies Pull requests that update a dependency file pkg:create-react-router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants