Skip to content

Conversation

remorses
Copy link
Contributor

@remorses remorses commented Jul 31, 2025

Previously react-router was using fs-extra for rename which supported renaming a file into a folder that does not exist
https://github.com/jprichardson/node-fs-extra/blob/176ad6a6dbdec503c2d79fa70d17df32dff49972/lib/move/move-sync.js#L36

Now we need to manually create the folder, issue caused by #13736

CC/ @43081j, @benmccann & @outslept

Copy link

changeset-bot bot commented Jul 31, 2025

🦋 Changeset detected

Latest commit: 58abb93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title fix: rename without mkdir in Vite plugin fix(dev/vite): fix rename without mkdir Jul 31, 2025
@43081j
Copy link
Contributor

43081j commented Aug 1, 2025

Good catch! Makes sense to me 👍

Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@markdalgleish markdalgleish merged commit 5a1786f into remix-run:dev Aug 4, 2025
14 checks passed
Copy link
Contributor

github-actions bot commented Aug 5, 2025

🤖 Hello there,

We just published version 7.8.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Aug 7, 2025

🤖 Hello there,

We just published version 7.8.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants