[added] <DefaultRoute> component

[mjackson]

Also, changed behavior of routes with no name, path, or children so
they act as default routes. is essentially just sugar.

Fixes #164
Fixes #193

[ryanflorence]

we need @spicyj to show us how to do this properly before the next release of react, apparently we are cheating here and need to make components, not just functions that can trick JSX, but for now

[mtscout6]

Do you by chance mean that something like <Route to='somewhere' handler={ShellHandler} defaultHandler={DefaultHandler} /> would be more correct instead? Definitely easer then doing checks to make sure there is only one DefaultRoute child.

[ryanflorence]

No, I mean how do we make a real component out of <DefaultRoute/> instead of just a function that jsx thinks is a component.

[mtscout6]

Gotcha, thanks for the clarification.

[sophiebits]

You can imagine that <DefaultRoute handler={Foo} /> will be compiled into {type: DefaultRoute, props: {handler: Foo}}. I am pretty sure that RegisterRoute will just have to understand what DefaultRoute is.

[ryanflorence]

crap, I messed this all up by merging 6d1ae95

[ryanflorence]

@mjackson is it intentional that you now have to specify path="/" on root routes?

<Routes>
  <Route handler={App}>
    <DefaultRoute handler={Index}/>
    ...
  </Route>
</Routes>

Doesn't work anymore. I thought maybe I needed to use DefaultRoute instead:

<Routes>
  <DefaultRoute handler={App}>
    <DefaultRoute handler={Index}/>
    ...
  </DefaultRoute>
</Routes>

But that doesn't work either.

[ryanflorence]

oh, I see now that it was intended for this to fix #193 ... anyway, I rebased with master, this branch no longer has conflicts.

[mjackson]

is it intentional that you now have to specify path="/" on root routes?

No, that's not intentional if it's true, but it shouldn't be. You should still be able to leave the path off as usual. Root routes get path="/" and nested routes get the path of their parent.

[mjackson]

6d1ae95 isn't really a fix AFAICT. It only satisfies his use case. This branch contains a real fix for #193.

[ryanflorence]

yeah, I already merged that, but have rebased this commit with master and removed it, all is well.

[ryanflorence]

No, that's not intentional if it's true, but it shouldn't be. You should still be able to leave the path off as usual. Root routes get path="/" and nested routes get the path of their parent.

Doesn't work. I had to add this: https://github.com/rackt/react-router/pull/200/files#diff-cfa924f8d5ffb353e9d877f0273257efR51

[mjackson]

Doesn't work.

ok, it does now. I've updated the examples and fixed the bug. I'll let you merge when you think it's ready.

[adregan]

FWIW,I found that the path="/" on root Routes was only necessary once I redirected the root (default handler work around).