Warn on attempting to change <Router routes> #2581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -60,6 +60,12 @@ class Router extends Component { | |||
| nextProps.history === this.props.history, | |||
| 'You cannot change <Router history>; it will be ignored' | |||
| ) | |||
|
|
|||
| warning( | |||
| (nextProps.routes || nextProps.children) === | |||
There was a problem hiding this comment.
Inlined so babel-plugin-dev-expression will strip the whole statement.
|
I don't think we need a CHANGES entry for this (so I didn't add one). |
taion
added a commit
that referenced
this pull request
Nov 26, 2015
Warn on attempting to change <Router routes>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.