add module entry point for webpack v2 #3788 #3789
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref my note in #3788 (comment). There's definitely an (odd, unexpected) cost to this. I'm not sure this is a good idea. |
|
That seems like more of a webpack and babel problem. Given that webpack 2 isn't out of beta, not lot of people are going to be running into the issue just yet. Those that are would be accepting the cost of running beta software: rough edges like these. I wouldn't want to just hand wave over the issue, but good saved reply should take care of the workload on us. |
|
I'm going to close this out since it's against master. It should be only on the v3 branch, which already has a jsnext:main |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.