Skip to content

Remove instanceof check from isRouteErrorResponse #9930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Remove instanceof check from isRouteErrorResponse #9930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silver-snails-destroy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/router": patch
---

Remove instanceof check from isRouteErrorResponse to avoid bundling issues on the server
12 changes: 9 additions & 3 deletions packages/router/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1395,8 +1395,14 @@ export class ErrorResponse {

/**
* Check if the given error is an ErrorResponse generated from a 4xx/5xx
* Response throw from an action/loader
* Response thrown from an action/loader
*/
export function isRouteErrorResponse(e: any): e is ErrorResponse {
return e instanceof ErrorResponse;
export function isRouteErrorResponse(error: any): error is ErrorResponse {
return (
error != null &&
typeof error.status === "number" &&
typeof error.statusText === "string" &&
typeof error.internal === "boolean" &&
"data" in error
);
}