Skip to content

Update popstate warning when popping to an unknown location #9941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2023
Merged

Update popstate warning when popping to an unknown location #9941

merged 3 commits into from
Jan 19, 2023

Conversation

brophdawg11
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7976b71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

brophdawg11
brophdawg11 commented Jan 19, 2023
View reviewed changes
packages/router/history.ts Outdated
`created by @remix-run/router. This won't work and will fail silently ` +
`in production. In general, you should do all navigation with the ` +
`router to avoid this situation (instead of using window.history.pushState ` +
`or assigning directly to window.location.hash).`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning was specific to blocking but also applies to direct window.location.hash assignments so I made it a bit more generic

@timdorr timdorr mentioned this pull request Jan 19, 2023
Closed
@brophdawg11 brophdawg11 merged commit abf222b into dev Jan 19, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/update-pop-warning branch January 19, 2023 19:53
This was referenced Jan 20, 2023
Closed
Closed
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.7.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.8.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brophdawg11 @MichaelDeBoey @timdorr