Skip to content

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 28, 2023

Placeholder types for ES6 collections were added to the Js namespace in rescript-lang/rescript#5630.

We should use these in Core.

@cknitt cknitt requested review from cristianoc and zth May 28, 2023 18:39
Copy link
Member

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a changelog?

@zth zth merged commit 7d498f7 into main May 28, 2023
@zth zth deleted the use-js-collection-types branch May 28, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants