Skip to content

Fix type of Nullable.t which was not untagged in the implementation. #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Fix type of Nullable.t which was not untagged in the implementation. #235

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80af131
Fix type of `Nullable.t` which was not untagged in the implementation.
cristianoc Jun 13, 2024
54d14e6
More fixes w.r.t. compiler master.
cristianoc Jun 13, 2024
c867c56
Use #"best fit"
cristianoc Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Next version

- BREAKING: Fixes the type of `RegExp.Result.t` to be `array<option<string>>` instead of `array<string>`. https://github.com/rescript-association/rescript-core/pull/234.
- Fix type of `Nullable.t` which was not untagged in the implementation. https://github.com/rescript-association/rescript-core/pull/235

## 1.4.0

Expand Down
1 change: 1 addition & 0 deletions src/Core__Nullable.res
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
@unboxed
type t<'a> = Js.Nullable.t<'a> =
| Value('a)
| @as(null) Null
Expand Down
2 changes: 1 addition & 1 deletion src/intl/Core__Intl__Common.res
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
type localeMatcher = [#lookup | @as("best fit") #bestFit]
type localeMatcher = [#lookup | #bestFit]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still seems wrong. It should be #"best fit".

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat/NumberFormat#localematcher


type calendar = [
| #buddhist
Expand Down
2 changes: 1 addition & 1 deletion src/intl/Core__Intl__DateTimeFormat.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ type timeZoneName = [
]

type hourCycle = [#h11 | #h12 | #h23 | #h24]
type formatMatcher = [#basic | @as("best fit") #bestFit]
type formatMatcher = [#basic | #bestFit]
type fractionalSecondDigits = [#0 | #1 | #2 | #3]

type options = {
Expand Down