Skip to content

chore(ci): add style check workflow #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2023

Conversation

glennsl
Copy link
Contributor

@glennsl glennsl commented Feb 19, 2023

No description provided.

@glennsl
Copy link
Contributor Author

glennsl commented Feb 19, 2023

Tested that it fails when it should on my own fork. See https://github.com/glennsl/rescript-core/actions

@zth
Copy link
Collaborator

zth commented Feb 19, 2023

Cool! Can we add a description somewhere that shows up in GitHub that you'll need to format all files (and point to the command to do that)? Just do people understand what's wrong when this fails.

@glennsl
Copy link
Contributor Author

glennsl commented Feb 19, 2023

@zth
Copy link
Collaborator

zth commented Feb 19, 2023

Fantastic, thank you very much!

@zth zth merged commit cb4e0c9 into rescript-lang:main Feb 19, 2023
@glennsl glennsl deleted the chore/ci/style-check branch February 19, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants