Skip to content

chore(test): fix undefined __dirname in node 19 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

glennsl
Copy link
Contributor

@glennsl glennsl commented Feb 19, 2023

__dirname is apparently in es modules as of node 19. This fixes that by using import.meta.url instead.

Also adds current and latest LTS node versions (19 and 18 respectively) to the CI matrix.

Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@zth zth merged commit 529452e into rescript-lang:main Feb 20, 2023
@glennsl glennsl deleted the chore/test/__dirname-undefined branch February 20, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants