Show the number of errors and warnings in the Problems tab's title

[mediremi]

• Show the number of errors and warnings in the Problems tab's title

• Use Int.toString instead of Belt.Int.toString if the ReScript major version is 11+
• Tidy up the React and Console panels in the Output tab

Before	After

• Only show syntax selection if there are at least 2 syntaxes to choose from
• Improve styles for warnings flags input

Before	After

[vercel]

@mediremi is attempting to deploy a commit to the ReScript Association Team on Vercel.

A member of the Team first needs to authorize it.

[mediremi]

Using onClick instead of onMouseDown makes the tabs keyboard accessible - buttons with a click handler can be triggered with Enter/Space.

[fhammerschmidt]

This might have been an optimisation so that event.preventDefault() gets invoked faster. Or maybe it was deliberate that it does not get focused.

@ryyppy do you still remember?

[ryyppy]

there was most likely a good reason. I think it had something to do with touch event delay. Ultimately one should consider adapting a accessibility component lib like react-aria to have a fully accessible tab bar etc.

[mediremi]

I've removed warnings 40 and 42 from warn_flags as they no longer exist in the compiler: https://github.com/rescript-lang/rescript/blob/9a8f133f6f1bbc84975efceb8113b767805fbcfd/compiler/ext/warnings.mli#L57-L59

I've made a separate PR to the compiler repo for updating Bsc_warnings.defaults_w, which also still includes these warnings.

[mediremi]

I've also removed warnings:

• 61: no longer exists
• 109: not included in Bsc_warnings.defaults_w

[fhammerschmidt]

We support older compiler versions here, which might still support those warnings?

[fhammerschmidt]

We should probably have modern (V12-level) warning defaults, just when v12 is selected, and keep this one for the older compilers.

[mediremi]

The default warnings come from the compiler (specifically, with RescriptCompilerApi.Compiler.getConfig) - this string just determines the warnings used when the user clicks on [reset] in the 'Warning Flags' section.

Ideally, we'd want to reset the warnings to the initial defaults the compiler returned, but I couldn't figure that out. So I've restored the value of this string back to what it was before ("+a-4-9-20-40-41-42-50-61-102-109")

[fhammerschmidt]

This is gone? We still need this (for v11 at least).

[mediremi]

I renamed this callback to onWarningFlagsResetClick to make it clearer that this is triggered by clicking on [reset] in the 'Warnings flags' section of the settings panel.

[mediremi]

I removed the open_modules update part of this function as:
i) there's no way for users to configure open modules (at least as far as I can tell)
ii) the updating of open_modules on compiler load and switch is actually managed by the useEffect in CompilerManagerHook - this was just duplicated logic from CompilerManagerHook.getOpenModules

[fhammerschmidt]

Great stuff.
I think I would prefer having the number of problems after the title though.

Also great that you took on a little refactor here, but I am afraid we need to support older versions as well so if you adapt to something that only exists in v12, please guard it behind a version check.

[mediremi]

I think I would prefer having the number of problems after the title though.

I've moved the warning & error counts to after the title 👍

Also great that you took on a little refactor here, but I am afraid we need to support older versions as well so if you adapt to something that only exists in v12, please guard it behind a version check.

Now that I've restored the warning flags reset value, I think everything should still work on older versions exactly as it did before. I've had a quick check with versions 8 through 12, and everything seems to work fine.

Let me know if I've broken anything and I'll be happy to add version checks