Skip to content

Conversation

cristianoc
Copy link
Contributor

No description provided.

@cristianoc cristianoc mentioned this pull request Nov 9, 2022
57 tasks
@cristianoc cristianoc requested a review from zth November 9, 2022 08:19
Copy link
Member

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@@ -50,7 +41,7 @@ structure:
```js
//...
"gentypeconfig": {
"language": "typescript" | "flow" | "untyped",
"language": "typescript",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for now, but should we remove this configuration option all together now that it just supports one? Or am I misunderstanding?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're using compiler 10.0 or earlier, this is still required. I'll say that explicitly.

@cristianoc cristianoc merged commit bcfa75f into master Nov 9, 2022
@cristianoc cristianoc deleted the gentype branch November 9, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants