Skip to content

split off compiler as dev dependencies #3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bobzhang opened this issue May 23, 2019 · 3 comments
Closed

split off compiler as dev dependencies #3559

bobzhang opened this issue May 23, 2019 · 3 comments

Comments

@bobzhang
Copy link
Member

Relevant issues:
Allowing compiled code delivery
Make bsb able to compile all third-party artifacts into the top-level lib
bs-json: Consider having the compiled JS in the package?
Separated npm package for bucklescript dependencies
Proposal to add bs-stdlib

Some high level issues to solve:

  • Should we prebuild stdlib
    It seems so, otherwise *.js files is not in distribution.
    Pre-build-cons:
    We need make sure that .cm[ji] is the same across all platforms,
    more logistics when bump minor version of compiler
    Pre-build-pros
    No need make bsb capable of building stdlib
  • How to ensure
    bs-platform-dev is consistent with the version of bs-platform
    It seems that we can add a version field check, and
    bsb always do such check in the beginning
@jordwalke
Copy link

For the "Make bsb able to copmpile all third-party artifacts into top level lib", I made a larger issue which includes that and a couple of other things that let us use (Yarn-pnp, and esy) here. Including the link in case it's relevant.

@TheSpyder
Copy link
Contributor

perhaps split the node package into three?

bs-platform
-> bs-compiler (peer-dev on bs-stdlib)
-> bs-stdlib

That way existing workflows aren't impacted, but projects that need to can depend on compiler (dev dep) and stdlib (normal dev) directly (and manage the potential version conflicts themselves).

@bobzhang
Copy link
Member Author

bobzhang commented Feb 2, 2021

landed in master

@bobzhang bobzhang closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants