Skip to content

build stdlib/belt using bsb itself #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bobzhang opened this issue Jun 6, 2019 · 2 comments
Closed

build stdlib/belt using bsb itself #3589

bobzhang opened this issue Jun 6, 2019 · 2 comments
Labels
discussion stale Old issues that went stale

Comments

@bobzhang
Copy link
Member

bobzhang commented Jun 6, 2019

As an part of #3559, we need treat stdlib/belt as an normal package

Two features needed:

  • Allow user to impose dependencies manually (not captured by ocamldep)
    notably CamlinternalFormatBasics, Pervasives

    Node and Node_fs has pseudo cycle dependencies
    This is hard to solve, we have to adapt the code, in general, handwritten namespace file should depend on modules

  • Allow conditional flags based on file pattern
    for example, it does not make sense to add -open Pervasives for pervasives module
    and its dependent

comments are welcome to make it more generally useful instead of specialized for building stdlib

@OlegLustenko
Copy link

I have a question from the reason-react side. Will it affect final bundle size?

@stale
Copy link

stale bot commented May 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Old issues that went stale label May 3, 2023
@stale stale bot closed this as completed May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion stale Old issues that went stale
Projects
None yet
Development

No branches or pull requests

2 participants