[esy] Read dependencies in esy from installation.json #3860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulrikstrid
changed the title
bsansouci
reviewed
Oct 7, 2019
| @@ -106,6 +106,22 @@ let pkg_name_as_variable package = | |||
| |> fun s -> Ext_string.split s '-' | |||
| |> String.concat "_" | |||
|
|
|||
| let rec find_dep_path ic package_name = | |||
There was a problem hiding this comment.
One thing you could do that might make this function simpler is make this function do the try/catch and return an option of string
Yeah, I think it is a good idea |
8 tasks
ulrikstrid
force-pushed
the
read-esy-sources
branch
from
723df36 to
8c4f836
Compare
|
@bobzhang I couldn't figure out how to make the computation lazy but I moved the try/catch to a better position and I think this is good to go now. I also rebased on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm piggy backing on the
custom_resolutionflag that is already set when building with esy here. If we can't find the dependency in the environment variables we'll look it up in theinstallation.jsonfile from the current sandbox.@bobzhang can I make the lookup per package be lazy somehow so that we don't have to do it multiple times?
Notes:
"buildsInSource": truewhich I think is valid and needed anyway.